[fix bug 1337448] FxA redirect after login.#4643
Merged
schalkneethling merged 1 commit intomozilla:masterfrom Feb 8, 2017
Merged
[fix bug 1337448] FxA redirect after login.#4643schalkneethling merged 1 commit intomozilla:masterfrom
schalkneethling merged 1 commit intomozilla:masterfrom
Conversation
jpetto
commented
Feb 7, 2017
| } | ||
|
|
||
| // client-side redirects (handy for testing) | ||
| function doRedirect(destination) { |
Contributor
Author
There was a problem hiding this comment.
This function helps us write unit tests against scripts that perform a redirect. Might be worth using this function in other places where we currently do window.location.href = , but that's another PR.
Contributor
Author
|
@schalkneethling - As Alex is out this week, and this is a fairly important fix, can you find time to review? Thanks! |
|
@jpetto Code looks good, js test all pass, and tested the redirection on demo3. r+ |
|
@jpetto, @schalkneethling - you guys are awesome. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#4579 introduced a regression whereby users logging in to the FxA iframe stopped being redirected to the FxA settings page. This resulted in a significant uptick in errors on the FxA side (which is how the bug was discovered), as well as poor UX (the user saw a "Working..." error message in the iframe that never went away).
This PR fixes that regression, and adds tests.
Bugzilla link
https://bugzilla.mozilla.org/show_bug.cgi?id=1337448
Testing
On demo3, using a profile configured to work with the FxA staging server, log in to Sync on the current firstrun page [1]. You should be redirected to the FxA accounts settings URL.
Also on demo3, using the same profile as above, log in to Sync on the soon to be released funnelcake firstrun page [2]. You should be redirected to the new tab view.
(Working with FxA on a demo is detailed in the docs.)
[1] https://www-demo3.allizom.org/en-US/firefox/51.0/firstrun/
[2] https://www-demo3.allizom.org/en-US/firefox/51.0/firstrun/?f=99
Checklist