[bug 859564] Student Ambassadors page styling.#823
[bug 859564] Student Ambassadors page styling.#823glogiotatidis wants to merge 1 commit intomozilla:masterfrom
Conversation
There was a problem hiding this comment.
missed l10n for alt text.
There was a problem hiding this comment.
nice catch. updated.
|
I'm not able to test submitting the form, as I'm getting an error with the captcha: |
|
@sgarrity That doesn't ring a bell. Maybe try to register for you own captcha keys. Or you can remove captcha from both the form (https://github.com/mozilla/bedrock/blob/master/apps/mozorg/forms.py#L213) and the template (lines 125-126) and test it without the captcha. |
|
Got the captcha working with a new local key. Thanks. If you select "Student" as your "Current Status", but leave other required fields blank and submit, when the page re-loads there is a "Select graduation year". However, the graduation year flydown is hidden until you unselect and then re-select "Student". The JS that un-hides the secondary flydown menus should also run on page load. |
|
Getting this message when submitting the form with all fields filled-in: |
|
There were some mismatching info. The newsletter added to basket was called "ambassadors" but the form is trying "student-ambassadors". It's trying to connect to the target "custom_student_ambassadors", where the actual url at basket is "custom_update_student_ambassadors". The bigger deals are the issue with the validation that @sgarrity brought up, and the fact that there is no success message or page. It just reloads the form with all your information sill filled in if it succeeds. |
Add base styles updated responsive layout add input placeholder js shim
|
Updated with a success message, fixed the hidden fields issue and updated the mismatching info. Thanks for the feedback all! |
There was a problem hiding this comment.
This will be true even if an exception is caught. This should be in an else clause on the try:.
Even if this success message is displayed though, if they refresh that page they'll get the "resubmit data" alert, and they could submit again. I really prefer for there to be a separate thank-you page to which to send them on success. This should be pretty easy.
|
Working on a new PR for this. Since the original changes on which these are based were reverted, this will no longer apply cleanly. I've cherry picked this commit into my branch and will submit a new PR soon. |
Add base styles
updated responsive layout
add input placeholder js shim