Skip to content

Clarify working tree state for revision follow-ups #6780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suhaibmujahid merged 1 commit into from
Sep 3, 2026
+2 −0
Merged

Clarify working tree state for revision follow-ups #6780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions agents/bug-fix/hackbot_agents/bug_fix/prompts/follow-up.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ Respond only to the comments quoted below. Ignore any earlier mentions of you el

A quoted comment rarely stands alone: an inline one only makes sense next to the code it sits on. Before acting, use the `phabricator` tools to read D{revision_id} and its thread, and to locate the comment context so you can understand it. Your tree is at the revision's latest diff, so a comment on an older `diff_id` may point at code that has since changed.

The working tree starts with D{revision_id}'s latest diff applied as uncommitted changes on top of its base commit. These initial changes belong to the existing revision, not this run.

Then address each quoted comment by taking the matching path:

- If it requests a code change (a fix, tweak, or follow-up to the patch): make the necessary source changes, verify them, and call phabricator_update_patch with revision_id={revision_id} so the existing revision D{revision_id} is updated.
Expand Down