Trigger test tasks selected by bugbug and publish test results on Phabricator#264
Trigger test tasks selected by bugbug and publish test results on Phabricator#264marco-c merged 4 commits intomozilla:masterfrom
Conversation
8ec2ec2 to
fa9bd48
Compare
La0
left a comment
There was a problem hiding this comment.
I'm not happy with the current situation where we put more & more stuff in code-review events, at the risk of breaking the relative stability we have acquired.
One solution i would like to try, is to put the code in there, but not execute everything on the same instance.
We now have multiple dynos running in production: 1 web dyno + N worker dyno. That works because the web dyno is the only one queueing in the build queue. But adding pulse listeners on every workers would be bad.
So we should add feature flags to activate web+pulse queuing on the web dyno and heavy lifting on worker dynos. On dev you could have everything running at once.
| # self.workflow.run(), | ||
| # Add mercurial task | ||
| self.mercurial.run(), | ||
| # self.mercurial.run(), |
There was a problem hiding this comment.
Let's not forget to remove those
There was a problem hiding this comment.
Why? This was the one change that reduced the risk of new bugs to 0!
La0
left a comment
There was a problem hiding this comment.
Why don't we have a separate instance of events for this stuff already ?
532a104 to
c540e46
Compare
|
As discussed on IRC, a good middle ground is having it as a separate async task communicating with the main workflow using queues. |
63be68e to
60ec7f8
Compare
60ec7f8 to
ba98b92
Compare
\o/ |
No description provided.