Skip to content

Support listening on multiple queues and routes on the same pulse connection#19

Merged
La0 merged 3 commits intomasterfrom
support_multiple_queues
Nov 26, 2019
Merged

Support listening on multiple queues and routes on the same pulse connection#19
La0 merged 3 commits intomasterfrom
support_multiple_queues

Conversation

@marco-c
Copy link
Copy Markdown
Collaborator

@marco-c marco-c commented Nov 25, 2019

I'll rebase once #18 lands.

@La0
Copy link
Copy Markdown
Contributor

La0 commented Nov 26, 2019

I pushed a modification to your PR to add the routing information in the message sent to clients.
The events pulse clients would receive a payload enabling them to triage the payloads using exhange & routes. I also found the other routes (which are the ones we are mostly intrested in for triage)

{'body': {'runId': 0,
          'status': {'deadline': '2019-11-27T05:36:19.459Z',
                     'expires': '2020-11-25T05:36:19.459Z',
                     'provisionerId': 'gecko-t',
                     'retriesLeft': 5,
                     'runs': [{'reasonCreated': 'scheduled',
                               'reasonResolved': 'completed',
                               'resolved': '2019-11-26T08:28:21.535Z',
                               'runId': 0,
                               'scheduled': '2019-11-26T07:51:33.267Z',
                               'started': '2019-11-26T08:04:56.852Z',
                               'state': 'completed',
                               'takenUntil': '2019-11-26T08:41:57.869Z',
                               'workerGroup': 'aws',
                               'workerId': 'i-03e2be4d85264417e'}],
                     'schedulerId': 'gecko-level-3',
                     'state': 'completed',
                     'taskGroupId': 'acRnT7fsQvaibi0I3-cLZA',
                     'taskId': 'CJyfokx5Sjaw39liC1skDw',
                     'workerType': 't-win7-32-gpu'},
          'task': {'tags': {'createdForUser': 'gwatson@mozilla.com',
                            'kind': 'test',
                            'label': 'test-windows7-32-shippable/opt-reftest-no-accel-e10s-4',
                            'os': 'windows',
                            'retrigger': 'true',
                            'test-type': 'reftest',
                            'worker-implementation': 'generic-worker'}},
          'version': 1,
          'workerGroup': 'aws',
          'workerId': 'i-03e2be4d85264417e'},
 'routing': {'exchange': 'exchange/taskcluster-queue/v1/task-completed',
             'key': 'primary.CJyfokx5Sjaw39liC1skDw.0.aws.i-03e2be4d85264417e.gecko-t.t-win7-32-gpu.gecko-level-3.acRnT7fsQvaibi0I3-cLZA._',
             'other_routes': [b'route.tc-treeherder.v2.autoland.40fc032b53b7'
                              b'e6bbe186425f89defbead3491b7e.101555',
                              b'route.coalesce.v1.autoland.1b40bdf4a8bf581fe'
                              b'30f']}}

@marco-c
Copy link
Copy Markdown
Collaborator Author

marco-c commented Nov 26, 2019

The commit you added looks good to me!

@marco-c marco-c force-pushed the support_multiple_queues branch from ca65ded to 6ade818 Compare November 26, 2019 09:33
Copy link
Copy Markdown
Contributor

@La0 La0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this awesome piece of collaborative work.

@La0 La0 merged commit 0082aae into master Nov 26, 2019
@La0 La0 deleted the support_multiple_queues branch November 26, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants