Skip to content
This repository was archived by the owner on Oct 13, 2021. It is now read-only.

setup.py: ship the clang plugin#110

Closed
mook wants to merge 1 commit intomozilla:masterfrom
mook:setup-ship-clang-plugin
Closed

setup.py: ship the clang plugin#110
mook wants to merge 1 commit intomozilla:masterfrom
mook:setup-ship-clang-plugin

Conversation

@mook
Copy link
Contributor

@mook mook commented Feb 24, 2013

Without this, installed packages don't work very well for indexing.

Note that I don't know my way around setuptools/distribute/whatever so don't trust me on this - it's more of a bug report that not doing this doesn't work, I guess? Anyway, with setup.py install, it didn't include the .so so actually using clang wasn't very productive. If we're going to ship the rest of the clang plugin anyway...

Without this, installed packages don't work very well for indexing
@erikrose
Copy link
Contributor

erikrose commented Mar 5, 2013

The idea is sane, though we should probably use MANIFEST.in instead. I vaguely recall package_data being a distutils thing, obsolete, and unreliable in some way.

I can see us leaving trilite out of this mix for now, since we have not-quite-horrible instructions in deployment.mkd about installing it. However, perhaps it would be friendlier to install it, too.

erikrose added a commit to erikrose/dxr that referenced this pull request May 30, 2013
…nstall" installations can actually find their templates.

We have yet to figure out how to ship compiled plugins, like the clang one. Ref mozilla#110.
@erikrose
Copy link
Contributor

erikrose commented Jun 7, 2013

We could probably make a custom distutils Command (and build_ext) subclass and trigger it from setup(ext_modules=[that class]). We can probably do whatever we want from a command, including building the shared libs. Ideally, setup() won't be too disappointed that an extension module isn't actually built. See M2Crypto's setup.py for an example of a custom build_ext subclass.

Then doing setup.py install will run make, and we'll be able to build arch-specific eggs with all the shared libs (maybe even trilite!) included.

@erikrose erikrose closed this in 4c2b41d Jun 10, 2013
@erikrose
Copy link
Contributor

Moved the automatically-run-make thread to a dedicated bug: https://bugzilla.mozilla.org/show_bug.cgi?id=881490.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants