Skip to content

Conversation

@tdsmith
Copy link
Contributor

@tdsmith tdsmith commented Mar 24, 2021

Description (optional)

Clarify that Jetstream isn't monitoring.

Issue that this pull request resolves (optional)

Together with #4, closes mozilla/jetstream#529.

Closes: mozilla/experimenter#0000

Permission checklist

Put an x in the boxes that apply. These options exist to reduce pull request process friction.

  • I grant permission for a reviewer to make small adjustments for me including typo fixes, Markdown/MDX improvements, title or sidebar (ID) suggestions, etc. so long as these changes do not impact the content of the documentation. I understand the reviewer may leave comments instead of doing this for me depending on who reviews it.
  • I have not ran the project locally with my changes and it would be be ideal for the reviewer to check into my branch and ensure images etc. are rendering as expected.
  • I grant permission for a reviewer to merge this pull request for me once it has been approved.

@tdsmith tdsmith requested a review from emtwo March 24, 2021 18:24
**experiment configurations** <!-- TODO: linkme -->
to jetstream-config.

Jetstream is not a monitoring platform,
Copy link
Contributor

@k88hudson k88hudson Mar 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend framing this as a "how to" i.e.

Jetstream does not emit real-time events – if you are looking for monitoring tools,
currently your best options are [link to Grafana docs etc.]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some monitoring related docs here: https://docs.telemetry.mozilla.org/datasets/experiment_monitoring.html
Currently, outdated but I'm updating them now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't disagree but I don't think we have documentation for monitoring and I don't think we're going to write any yet. The dataset documentation is probably too technical.

I submit that this is a useful clarification to the doc and that we should merge it.

@tdsmith tdsmith requested review from k88hudson and scholtzan March 26, 2021 00:07
@k88hudson k88hudson merged commit 5a9c03a into main Mar 26, 2021
@freshstrangemusic freshstrangemusic deleted the jetstream-isnt-monitoring branch April 16, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write a high-level overview of Jetstream

4 participants