Revert "feat(nimbus): Always fetch newer results" - #16152
Merged
Conversation
This reverts commit e07250a.
RJAK11
requested review from
freshstrangemusic,
jaredlockhart,
mikewilli and
yashikakhurana
as code owners
June 30, 2026 16:51
yashikakhurana
approved these changes
Jun 30, 2026
RJAK11
added a commit
that referenced
this pull request
Jul 22, 2026
Because * the fetch task used experiment status and a fixed time window to decide when to fetch results * #15871 changed this to fetch whenever an experiment has newer results, but was reverted in #16152 after invalid metadata for older experiments crashed the fetch loop This commit * reland the reverted #15871 changes that fetch results when an experiment's analysis start time is newer than the stored one Fixes #15737
RJAK11
added a commit
that referenced
this pull request
Jul 22, 2026
Because * Jetstream writes metadata for some older experiments that is missing fields the current schema requires (e.g. analysis_bases) * validating that metadata raises a ValidationError that we do not catch * this crashed the whole fetch loop and is why #15871 was reverted (#16152) This commit * report the error to Sentry and skip the experiment instead of raising, in both the main loop (get_latest_analysis_start_time) and the fetch task (fetch_experiment_data), so invalid data is never stored or surfaced and one bad experiment cannot abort the fetch for the others * add tests that reproduce the schema validation error reported in Sentry Fixes #16203
RJAK11
added a commit
that referenced
this pull request
Jul 27, 2026
Because * Jetstream writes metadata for some older experiments that is missing fields the current schema requires (e.g. analysis_bases) * validating that metadata raises a ValidationError that we do not catch * this crashed the whole fetch loop and is why #15871 was reverted (#16152) This commit * report the error to Sentry and skip the experiment instead of raising, in both the main loop (get_latest_analysis_start_time) and the fetch task (fetch_experiment_data), so invalid data is never stored or surfaced and one bad experiment cannot abort the fetch for the others * add tests that reproduce the schema validation error reported in Sentry Fixes #16203
yashikakhurana
pushed a commit
to dharhar/experimenter
that referenced
this pull request
Jul 28, 2026
Because * the fetch task used experiment status and a fixed time window to decide when to fetch results * mozilla#15871 changed this to refresh whenever an experiment has newer results, but was reverted in mozilla#16152 after metadata for some older experiments failed schema validation and aborted the fetch task This PR * relands the mozilla#15871 changes that fetch results when an experiment has newer results * catches ValidationError when reading metadata, reports it to Sentry and skips only that experiment so a single experiment with invalid metadata no longer breaks the whole fetch Fixes mozilla#16203
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #15871