Issue-1074 Llink to retiring extension example #2183
Conversation
dotproto
left a comment
dotproto
left a comment
There was a problem hiding this comment.
Looks good. I only have a couple minor nits that don't need additional review and an observation that should be split into a new issue.
| - You plan to remove support for a product or service. In this case, you’ll want to remove the extension from browsers when support ends. | ||
|
|
||
| - You're replacing the extension with a new one, which isn't a direct upgrade. In this case, you'll want to encourage existing users to install the new extension, before you remove the old extension from browsers. | ||
| - You’re replacing the extension with a new one, which isn’t a direct upgrade. In this case, you’ll want to encourage existing users to install the new extension before removing the old one from their browsers. |
There was a problem hiding this comment.
Note
After writing this comment, I realized this is too big to tackle here. I'm mostly commenting so we can split this out into a separate ticket.
This line caught my eye in part because it swaps apostrophes (U+00027) for right single quotation marks (U+02019). I've seen style guides that mandate one over the other. In my training, I recall being told that HTML content should use an apostrophe rather than a special Unicode character.
I don't want to go into a ton of detail here, but considerations here include the character encoding for the source file, the HTML document, places Unicode or HTML entities can be used, etc.
In order to get a sense of the patterns used in our existing content, I searched the .md files in this repo for a variety of contractions using both characters. For each contraction, the regular expression used followed the pattern \w<Character><Abbreviation>, where <Character> is either ' or ’ and <Abbreviation> was the abbreviated second word in the contraction. For example, \w's would match let's and \w’s would match let’s.
' (U+00027) regexp |
' (U+00027) occurrences |
’ (U+02019) regexp |
’ (U+02019) occurrences |
|---|---|---|---|
\w's |
188 results, 45 files | \w’s |
238 results, 51 files |
\w't |
120 results, 31 files | \w’t |
77 results, 29 files |
\w're |
25 results, 17 files | \w’re |
19 results, 13 files |
\w've |
13 results, 8 files | \w’ve |
13 results, 10 files |
\w'll |
7 results, 6 files | \w’ll |
10 results, 8 files |
\w'd |
8 results, 3 files | \w’d |
5 results, 5 files |
\w'(s|t|re|ve|ll) |
353 results, 56 files | \w’(s|t|re|ve|ll) |
357 results, 57 files |
The HTML entities ’ and ’ do not appear source files.
Co-authored-by: Simeon Vincent <svincent@gmail.com>
2 participants
This change fixes #1074 by adding a link to the extension example illustrating an option for the final version of a retiring web extension. Additionally, several edits were made to enhance the content and readability of the page.