Skip to content
This repository was archived by the owner on Mar 15, 2018. It is now read-only.

Categories header RTL support (bug 1148610)#1158

Merged
mstriemer merged 1 commit intomozilla:masterfrom
mstriemer:rtl-category-listing-1148610
Apr 23, 2015
Merged

Categories header RTL support (bug 1148610)#1158
mstriemer merged 1 commit intomozilla:masterfrom
mstriemer:rtl-category-listing-1148610

Conversation

@mstriemer
Copy link
Contributor

screenshot 2015-04-22 11 36 45 screenshot 2015-04-22 11 59 03

screenshot 2015-04-22 11 36 27 screenshot 2015-04-22 11 52 14

screenshot 2015-04-22 11 36 03 screenshot 2015-04-22 11 52 25

I changed the float on the preview toggle for the narrow RTL image, that is being updated in #1151.

@mstriemer mstriemer force-pushed the rtl-category-listing-1148610 branch from e1c31df to cb5b282 Compare April 22, 2015 17:00
@mstriemer
Copy link
Contributor Author

r? @spasovski

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ngoke prefers to have declarations at the top of the file. I like them closer to where they are used but we might want to be consistent and move these up.

@spasovski
Copy link
Contributor

r+

@mstriemer mstriemer force-pushed the rtl-category-listing-1148610 branch 2 times, most recently from ff1f7ca to 03d8861 Compare April 23, 2015 15:40
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added this change so there's spacing between "Popular" and "New".

screenshot 2015-04-23 10 41 32

mstriemer added a commit that referenced this pull request Apr 23, 2015
Categories header RTL support (bug 1148610)
@mstriemer mstriemer merged commit d59ee1d into mozilla:master Apr 23, 2015
@mstriemer mstriemer deleted the rtl-category-listing-1148610 branch April 23, 2015 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants