This repository was archived by the owner on Mar 15, 2018. It is now read-only.
Conversation
src/media/js/elements/header.js
Outdated
Contributor
There was a problem hiding this comment.
I think the _ should stay where it was. These normally match the dependencies format.
Contributor
There was a problem hiding this comment.
yeah. it should match the breaks above for AMD.
Contributor
|
r+ |
spasovski
added a commit
that referenced
this pull request
Jul 1, 2015
ie10 issue roundup part one (bug 1135213)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some issues still remain but I'll file separate bugs for those. Not sure how much time we should spend on these since Edge seems like it will cover all the older flexbox/event issues etc.