[Do not merge] Updated to send platform and form_factor to API #411
Conversation
hearth/media/js/apps.js
Outdated
There was a problem hiding this comment.
That's right, right?
robhudson
changed the title
|
@cvan Is this an r+? If not can you tell me what I need to do? Also, this shouldn't be merged until the monster patch on zamboni is merged and after prod has done a full re-index. My goal is to merge this to target the push after the patch in zamboni lands and we have 1 week for prod to do a re-index. By sending the updated query string params we change the queries to use the new fields in ES. |
There was a problem hiding this comment.
A review on these widths for mobile and tablet, please?
There was a problem hiding this comment.
There was a problem hiding this comment.
It's not clear to me what you want me to do exactly. I see the widescreen capability. Do you want me to use 710px instead of 768?
There was a problem hiding this comment.
No, no more device_type.
|
there are several failing unit tests: |
|
I ran the tests when I worked on this and they passed. I'll check it again. Thanks. |
|
this is an r- until the tests are passing for me and the other comments are addressed - thanks 😏 |
|
All tests pass now after e0d45e1 |
|
Things have changed. Closing. |
2 participants
No description provided.