Handle FxA sign in from email (bug 1080868)#714
Conversation
There was a problem hiding this comment.
just use window.location.href
|
@cvan How's this look? |
There was a problem hiding this comment.
seems fickle, but this should work for every Marketplace except -altdev.
|
I'm not sure I'm the best one to review this, since I barely understand how FxA works. @washort? |
There was a problem hiding this comment.
do we pass to FxA the URL of this page - so they redirect users here upon clicking that button in the confirmation email?
There was a problem hiding this comment.
This URL is included in the OAuth provider config, for example: https://github.com/mozilla/fxa-dev/blob/master/roles/oauth/templates/config.json.j2
There have been discussions of changing what's presented to the user upon email confirmation, but currently it does show that url.
There was a problem hiding this comment.
whoa, I wasn't expecting that to be hardcoded in FxA. maybe I'm misunderstanding things, or I'm living under a rock, but won't all this special casing make FxA difficult/impossible to implement by other folks. Persona, in comparison, seems to be more developer-friendly.
Handle FxA sign in from email (bug 1080868)
3 participants
https://bugzilla.mozilla.org/show_bug.cgi?id=1080868
Reuse the window that was used for FxA sign in if there is no
window.opener. This enables sign in when the user navigates to FxA from one of our pre-verified emails.See also mozilla/zamboni#2652.