Skip to content
This repository was archived by the owner on Mar 15, 2018. It is now read-only.

Bump fxpay to 0.0.9 for desktop payment fixes#972

Merged
kumar303 merged 1 commit intomozilla:masterfrom
kumar303:fxpay-bump
Jan 28, 2015
Merged

Bump fxpay to 0.0.9 for desktop payment fixes#972
kumar303 merged 1 commit intomozilla:masterfrom
kumar303:fxpay-bump

Conversation

@kumar303
Copy link
Copy Markdown
Contributor

No description provided.

@ngokevin
Copy link
Copy Markdown
Contributor

Unrelated, but is it possible we can get Casper e2e tests with payments stuff using our mock API?

@kumar303
Copy link
Copy Markdown
Contributor Author

I'm sure it's possible but when I last looked at those e2e tests I couldn't figure out much. There's good unit level coverage of the payments module now: https://github.com/mozilla/fireplace/blob/master/src/tests/payments.js I am more of a fan of unit tests because they tend to rely less on async madness.

kumar303 added a commit that referenced this pull request Jan 28, 2015
Bump fxpay to 0.0.9 for desktop payment fixes
@kumar303 kumar303 merged commit d0a4eda into mozilla:master Jan 28, 2015
@kumar303 kumar303 deleted the fxpay-bump branch January 28, 2015 19:20
@ngokevin
Copy link
Copy Markdown
Contributor

Nice. I spent the last 3-4 days sweeping through the E2E tests, and updated the testing docs. I don't feel like there's much async madness, the tests run pretty sync-y and block with all the waitFors. I feel it's nice to have, I'll revisit sometime.

@kumar303
Copy link
Copy Markdown
Contributor Author

sure, a smoke test or two wouldn't hurt. I don't think it makes sense to try and cover all permutations of payment errors in the e2e tests though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants