This repository was archived by the owner on Jan 31, 2018. It is now read-only.
Infer version 915695#142
Closed
willkg wants to merge 3 commits intomozilla:masterfrom
willkg:infer-version-915695
Closed
Infer version 915695#142willkg wants to merge 3 commits intomozilla:masterfrom willkg:infer-version-915695
willkg wants to merge 3 commits intomozilla:masterfrom
willkg:infer-version-915695
Conversation
This adds some code to infer the FxOS version from the Gecko version specified in the browser parts of the user agent. This isn't a perfect way to get the version--there's a bunch of data that doesn't have the right Gecko versions. However, it's probably accurate for certain Gecko versions. This includes a data migration that backfills the data.
This makes it easier to know which migration had what output. At some point p, we'll nix the output. But it's super helpful for knowing what happened during deployments.
Contributor
There was a problem hiding this comment.
This just overwrites the same thing above?
Member
Author
There was a problem hiding this comment.
Yeah... I'm not sure what the first one is there for. I'll nix it.
Member
Author
|
Sorry this was sloppy. I didn't do a quality pass on it because I needed to run off and make dinner. I should have waited to do the pr until later. |
Member
Author
|
^^^ That fixes the duplicate code and the None thing. |
Contributor
|
ok, that fixed it. i ran migration forwards and backwards and things worked with my (limited) data. also tests passed. r+ |
Member
Author
|
Landed: ff988bd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the firefox os detection code to also infer the firefox os platform and browser version from the browser parts of the user agent.
There's some data in production that has "wrong gecko versions", so the migration ignores those figuring I don't know what it is if it doesn't have a correct Gecko version.
To test, run the tests, run the migration forwards and backwards and test the web form with FirefoxOS browser.
r?