Skip to content
This repository was archived by the owner on Jan 31, 2018. It is now read-only.

[bug 1010006] Fix some test infrastructure issues#282

Merged
willkg merged 1 commit into
mozilla:masterfrom
willkg:1010006-fix-tests
May 15, 2014
Merged

[bug 1010006] Fix some test infrastructure issues#282
willkg merged 1 commit into
mozilla:masterfrom
willkg:1010006-fix-tests

Conversation

@willkg
Copy link
Copy Markdown
Member

@willkg willkg commented May 15, 2014

What got "fixed":

  • this comments out the LiveServerTestCase stuff because it's not
    working right because we rely on data migrations to run to set up the
    test database; once we fix that, we can re-enable LiveServerTestCase
    things
  • this fixes some tests in regards to the data context they're running
    in so they're not order dependent
  • this adds some helpful comments and removes some not helpful ones

Outstanding:

  • selenium needs to be updated
  • fix the infrastructure to not require data migrations so that we can
    re-enable LiveServerTestCase

r?

What got "fixed":

* this comments out the LiveServerTestCase stuff because it's not
  working right because we rely on data migrations to run to set up the
  test database; once we fix that, we can re-enable LiveServerTestCase
  things
* this fixes some tests in regards to the data context they're running
  in so they're not order dependent
* this adds some helpful comments and removes some not helpful ones

Outstanding:

* selenium needs to be updated
* fix the infrastructure to not require data migrations so that we can
  re-enable LiveServerTestCase
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this diffy stuff is really just "added a cache.clear() to tearDown and removed an obvious comment".

@willkg
Copy link
Copy Markdown
Member Author

willkg commented May 15, 2014

Added some notes so it's easier to follow in your storybook because there's a non-trivial amount of "wtf" here.

This is the first half of fixing that bug. I need this now so things aren't fux0rd. I'll fix the second half (removing the need to do data migrations) at some point when I'm not hurting for time.

To test:

  1. run the tests. ./manage.py test
  2. run the feedback tests ./manage.py test fjord/feedback/tests/

@willkg
Copy link
Copy Markdown
Member Author

willkg commented May 15, 2014

Oops--that second step should be:

  1. run feedback views tests ./manage.py test fjord/feedback/tests/test_views.py

@willkg
Copy link
Copy Markdown
Member Author

willkg commented May 15, 2014

Also, this reduces test run times for fjord:

  • master: 1m16s
  • this branch: 39s

@willkg
Copy link
Copy Markdown
Member Author

willkg commented May 15, 2014

Also, this decreases the time it takes to boil water on your stove. It realigns the laws of physics to work for you.

@rlr
Copy link
Copy Markdown
Contributor

rlr commented May 15, 2014

wow, crazy pants!!

@rlr
Copy link
Copy Markdown
Contributor

rlr commented May 15, 2014

Everything you commented makes sense. Tests pass. Ran 156 tests in 21.709s

r+

@willkg willkg merged commit 53791e9 into mozilla:master May 15, 2014
@willkg
Copy link
Copy Markdown
Member Author

willkg commented May 15, 2014

Landed: 53791e9 [bug 1010006] Fix some test infrastructure issues

@willkg willkg deleted the 1010006-fix-tests branch May 15, 2014 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants