This repository was archived by the owner on Jan 31, 2018. It is now read-only.
1016339 indexing fixes#295
Closed
willkg wants to merge 3 commits into
Closed
Conversation
This switches class arguments to class paths where they get serialized for celery tasks and tossed in the queue. This should reduce the range of possible problems we have creating and executing tasks in regards to deployments that carry changes to the classes involved.
Member
Author
|
These are pretty minor fixes. The second one is just a doc change. The first one changes the arguments to indexing tasks so that we're not passing classes around. Classes are objects and get serialized by celery to preserve state and then get tossed in the queue. This changes it because I don't care about class state--I just want to be able to use the methods on the class in the indexing tasks. Thus we use "class paths" as arguments because those are just strings. To test:
|
Contributor
|
Did you forget to -a fjord/search/utils.py?
|
Member
Author
|
Bah. I did. Let me fix that.... |
Member
Author
|
^^^ Adds missing files. Sorry about that. |
Contributor
|
yay! r+ |
Member
Author
|
Landed in 8967350 [bug 1016339] Change class args to class paths |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r?