This repository was archived by the owner on Jan 31, 2018. It is now read-only.
[bug 1026019] Rework bigram generation#308
Merged
willkg merged 1 commit intomozilla:masterfrom Jun 17, 2014
willkg:1026019-bigrams
Merged
[bug 1026019] Rework bigram generation#308willkg merged 1 commit intomozilla:masterfrom willkg:1026019-bigrams
willkg merged 1 commit intomozilla:masterfrom
willkg:1026019-bigrams
Conversation
Member
Author
|
To test:
It's pretty benign, so it won't crash. No one is using the bigrams-using stuff as far as I know. I wrote up bug 1026019 to cover making this better. So for now, this mostly just affects how fast we can reindex. |
This reworks the tokenizing part of bigram generation so that it's no longer (ab)using Elasticsearch to do the work. Now it does its own tokenizing. I also added some really rough tests to make sure the new tokenizing wasn't really horrible. The tests run roughly the same before and after the code changes. The new code handles the "add-on" case better--the old code broke that into "add" and "on" and then ditched "on".
Contributor
|
looks good. tests pass and all that. r+! |
Member
Author
|
Landed in dccfb76 [bug 1026019] Rework bigram generation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reworks the tokenizing part of bigram generation so that it's no
longer (ab)using Elasticsearch to do the work. Now it does its own
tokenizing.
I also added some really rough tests to make sure the new tokenizing
wasn't really horrible. The tests run roughly the same before and after
the code changes. The new code handles the "add-on" case better--the old
code broke that into "add" and "on" and then ditched "on".
This radically improves reindexing. Cuts reindexing times in half or better.
r?