[bug 1062436] Add flags app and Flag model#342
[bug 1062436] Add flags app and Flag model#342willkg merged 1 commit intomozilla:masterfrom willkg:1062436-flags
Conversation
|
This doesn't do much. Mostly just creates a new app with a single model that's got a m2m relationship with Response. For a given response, we'll add "spam" and "abuse" flags. Then we'll have a view where we can do "show me all the responses flagged with abuse". This should provide all that. |
There was a problem hiding this comment.
We talked about making the ManyToMany table with options for things like individual ids or something so that we could have multiple tags of the same type on one response. Did you decide to nix this or skip it for now?
There was a problem hiding this comment.
I decided to go for "very simple" for now. I added notes to all the bugs talking about how this is ultra-simple and just for the prototype.
So the code that runs spicedham will flag with "spam" and "abuse". Then we'll have buttons in the analyzer view I'll write that will add "wrong-spam" and "wrong-abuse" which covers the false positive and false negative cases and lets us do reports like "what are all the responses that aren't spam, but were marked as spam?"
There was a problem hiding this comment.
\o/ Just wanted to make sure this was a case simplifying things, instead of forgetting things.
|
This looks fine to me. I have a question about the M2M table, but assuming you left out the extra complications on purpose, r+. 🐹 |
|
Sweet--thanks! 🌈 |
[bug 1062436] Add flags app and Flag model
|
4f671e4 [bug 1062436] Add flags app and Flag model |
2 participants
r?