Skip to content
This repository was archived by the owner on Jan 31, 2018. It is now read-only.

[bug 1142093] Replace jingo-minify with django-pipeline#572

Closed
rehandalal wants to merge 4 commits into
mozilla:masterfrom
rehandalal:pipeline
Closed

[bug 1142093] Replace jingo-minify with django-pipeline#572
rehandalal wants to merge 4 commits into
mozilla:masterfrom
rehandalal:pipeline

Conversation

@rehandalal
Copy link
Copy Markdown
Contributor

f?

DO NOT MERGE until bug #1170183 is fixed. (https://bugzilla.mozilla.org/show_bug.cgi?id=1170183)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOOOOOOO!!!!!!!

@willkg
Copy link
Copy Markdown
Member

willkg commented May 12, 2015

This looks ok as far as I can tell.

  1. What do we need to change in the docs?
  2. What do we need to change to vagrant/vagrant_provision.sh?
  3. What do we need to change on the servers and do we need to do it before this lands?

@willkg
Copy link
Copy Markdown
Member

willkg commented May 19, 2015

I haven't heard anything on this for 6 days. Where's it at? Do you need help with things?

@willkg
Copy link
Copy Markdown
Member

willkg commented May 29, 2015

@rehandalal Don't worry about the vagrant side of things. I can figure that out or throw it into a bug for someone else to chew on.

@rehandalal rehandalal changed the title (WIP) [bug 1142093] Replace jingo-minify with django-pipeline [bug 1142093] Replace jingo-minify with django-pipeline May 31, 2015
@willkg
Copy link
Copy Markdown
Member

willkg commented Jun 1, 2015

Can you rebase this against master thus picking up all the changes in the last 3 weeks?

@willkg willkg mentioned this pull request Jun 1, 2015
@rehandalal
Copy link
Copy Markdown
Contributor Author

yay ^

@willkg
Copy link
Copy Markdown
Member

willkg commented Jun 1, 2015

Adding a note so I remember:

DO NOT MERGE until bug #1170183 is fixed. (https://bugzilla.mozilla.org/show_bug.cgi?id=1170183)

@willkg
Copy link
Copy Markdown
Member

willkg commented Jul 21, 2015

This branch is pretty old and a lot has changed. I'm going to close this PR out, grab @rehandalal's branch (with his permission) and then finish up the work. I'll create a new PR then.

@willkg willkg closed this Jul 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants