This repository was archived by the owner on Jan 31, 2018. It is now read-only.
[bug 1167192] In python, stop using the gettext from tower.#596
Merged
willkg merged 1 commit intomozilla:masterfrom Jun 10, 2015
Merged
[bug 1167192] In python, stop using the gettext from tower.#596willkg merged 1 commit intomozilla:masterfrom
willkg merged 1 commit intomozilla:masterfrom
Conversation
fjord/base/translation.py
Outdated
Member
There was a problem hiding this comment.
It looks like django has lazy versions already:
https://docs.djangoproject.com/en/1.8/topics/i18n/translation/#lazy-translation
Does that not work for what we're doing?
Contributor
Author
There was a problem hiding this comment.
oooh. thanks for looking into that! I'll use that
Contributor
Author
|
fixord ^^ |
Member
|
I ran the tests and they're fine. (No surprise there.) I went through the feedback in French and didn't see any missing strings. That's probably good enough for this. r+ |
willkg
added a commit
that referenced
this pull request
Jun 10, 2015
[bug 1167192] In python, stop using the gettext from tower.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in IRC, I created fjord/base/translation.py to create the lazy versions. I am open to other ideas.
r?