Skip to content
This repository was archived by the owner on Jan 12, 2022. It is now read-only.

Bug 1748353 Bump forecast horizon to end of 2022 - #42

Merged
jklukas merged 1 commit into
mainfrom
horizon-2022
Jan 4, 2022
Merged

Bug 1748353 Bump forecast horizon to end of 2022#42
jklukas merged 1 commit into
mainfrom
horizon-2022

Conversation

@jklukas

@jklukas jklukas commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

@jklukas
jklukas requested a review from scholtzan January 4, 2022 13:32
@jklukas

jklukas commented Jan 4, 2022

Copy link
Copy Markdown
Contributor Author

cc @xluo-ds Is this job still needed?

We extended to end of 2021 in #40 per request of Dan and Selena, but not sure if this remains relevant in 2022.

@xluo-ds

xluo-ds commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

@jklukas I haven't got any follow-up ask from them around MAU stuff, but let me confirm with Dan.

@jklukas

jklukas commented Jan 4, 2022

Copy link
Copy Markdown
Contributor Author

@jklukas I haven't got any follow-up ask from them around MAU stuff, but let me confirm with Dan.

Merging this change for now so that the job continues to run, but feel free to post here with result of discussion, and we can tear down the DAG that runs this job if it's no longer needed.

@jklukas
jklukas merged commit 4263e2b into main Jan 4, 2022
@jklukas
jklukas deleted the horizon-2022 branch January 4, 2022 18:00
@jklukas

jklukas commented Jan 4, 2022

Copy link
Copy Markdown
Contributor Author

The failed to publish due to an error in build. I'm guessing there's some dependency that's getting pulled in without a pinned version that's causing incompatibilities.

This was referenced Jan 4, 2022
@xluo-ds

xluo-ds commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

@jklukas I haven't got any follow-up ask from them around MAU stuff, but let me confirm with Dan.

Merging this change for now so that the job continues to run, but feel free to post here with result of discussion, and we can tear down the DAG that runs this job if it's no longer needed.

Sounds good! Talked to Dan, and I will update here once I hear back from him.

@jklukas

jklukas commented Jan 5, 2022

Copy link
Copy Markdown
Contributor Author

I've tried several follow-ups to get this working, but the job is still erroring out. I've turned off the DAG for now so that we don't sink any more time into this until we have a verdict from Dan.

@xluo-ds

xluo-ds commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

@jklukas just heard from Dan that Selena confirmed it's fine to shut down the forecast on MAU.

@xluo-ds

xluo-ds commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

@jklukas side question but related, I have a notebook written in Python and would like to run as a daily job with airflow. Arkadiusz is working on it this week, I want to bring it up in case that we can reuse what we have now for the MAU forecasting.

@jklukas

jklukas commented Jan 7, 2022

Copy link
Copy Markdown
Contributor Author

I have a notebook written in Python and would like to run as a daily job with airflow. Arkadiusz is working on it this week, I want to bring it up in case that we can reuse what we have now for the MAU forecasting.

If some of the code here can be reused, that's great. This repo was created before the more general https://github.com/mozilla/docker-etl repo, though. If your job makes sense to express as a docker container, then it's probably best to have it live in docker-etl, using pieces of the code here as scaffolding as needed. cc @akkomar

Given that both this MAU forecast job and the anomdtct job in this repo are no longer used, it probably makes sense to archive this repo.

@jklukas

jklukas commented Jan 7, 2022

Copy link
Copy Markdown
Contributor Author

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1749039 to track archiving of this repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants