This repository was archived by the owner on Apr 3, 2019. It is now read-only.
bAdCAsE error - #522
Merged
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
does the article bind to "email" or "parameter" when email is back-ticked? English is hard. 🎲
Contributor
There was a problem hiding this comment.
indeed; forget the grammar, ship it!
Contributor
There was a problem hiding this comment.
"a parameter by the name of email..." :-P
Contributor
|
It seems a bit weird to have |
Contributor
Author
we could change the function name to |
rfk
pushed a commit
that referenced
this pull request
Oct 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits the old
Incorrect passworderror to add a separate error forIncorrect email case. When the auth fails and the request email doesn't match the database's case it will return this new error.The new errno is 120 with status code 400.
r? @rfk @chilts
cc @ncalexan
I'm lazy and did this on top of #521 so lets please review/merge that one first.