This repository was archived by the owner on Apr 3, 2019. It is now read-only.
chore(recovery-key): Remove all recovery key experiment code.#6766
Merged
Conversation
shane-tomlinson
force-pushed
the
recovery-key-experiment-simplify
branch
from
December 20, 2018 13:45
283c57e to
b7d0c4c
Compare
vbudhram
approved these changes
Dec 20, 2018
vbudhram
left a comment
Contributor
There was a problem hiding this comment.
@shane-tomlinson This LGTM 👍. @irrationalagent I know that we have an airtable feature to track the long affects of the change, if we remove the experiment can we still track it?
Recovery keys are a full feature, there is no longer a need to retain the experiment code and gating logic. Not attached to an issue.
shane-tomlinson
force-pushed
the
recovery-key-experiment-simplify
branch
from
December 21, 2018 19:42
b7d0c4c to
6d64c59
Compare
Author
|
@irrationalagent from Slack:
|
Author
Flow events are still there! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovery keys are a full feature, there is no longer a need
to retain the experiment code and gating logic.
Not attached to an issue, I noticed when looking at the latest recovery email text and it still has the
?showRecoveryKeyquery parameter.@vbudhram - r?