fix(settings): Get email from account hook instead of location state

[jonalmeida]

⚠️ I'm not really sure, what the right behaviour should be if the email is null.

Because

• We want to handle the missing email case and not get this information from the location state.

This pull request

• Switches to using currentAccount.

Issue that this pull request solves

Closes: FXA-10876

Checklist

Put an x in the boxes that apply

• My commit is GPG signed.
• If applicable, I have modified or added tests which pass locally.
• I have added necessary documentation (if appropriate).
• I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

n/a

Other information (Optional)

Built on top of #18136. Will rebase when the prior PR lands.

[LZoog]

💩 🤣

currentAccount pulls from local storage right, which is what we want most of the time 👍 but just from a quick search, I only see us call storeAccountData in CompleteResetPassword so is this available from local storage at this point in the flow...? If not, then location state seems like maybe the correct place?

To hopefully answer the code comment question, before the return (<ResetPasswordWithRecoveryKeyVerified can we just check that these values are non-null and if so, redirect? See how we check for !email in the signin container component. (I don't think this is applicable here but if we ever have a case where we're passing non-null values into a component just to pass them back to a callback, we can curry them, see InlineRecoveryKeySetup and SetPassword containers)

FWIW related to your PR title, we shouldn't be using useAccount unless we want the entire GQL query to run, we've got a ticket to remove it in reset PW.

[vpomerleau]

This page is reached after CompleteResetPassword so email should be stored in local storage at this stage - if it isn't, that means the user isn't signed in and should likely be redirected to /signin

[LZoog]

Ah thanks Valerie, I can never keep these reset PW flows straight. So yeah, currentAccount is the right thing here and I think if the value is null we can just redirect to /signin as you said.

[jonalmeida]

Thanks for the discussion! I've updated the PR and had to rebase it on #18156 for now.

FWIW related to your PR title, we shouldn't be using useAccount unless we want the entire GQL query to run, we've got a ticket to remove it in reset PW.

Sorry, that was a typo - I meant currentAccount. This seems to be the right one that also accounts for the email that comes from a web channel message.

[vpomerleau]

LGTM! 🚢