Skip to content

feat(auth): Restore write-emails-to-disk script#18189

Merged
LZoog merged 1 commit intomainfrom
restore-write-emails-to-disk
Jan 15, 2025
Merged

feat(auth): Restore write-emails-to-disk script#18189
LZoog merged 1 commit intomainfrom
restore-write-emails-to-disk

Conversation

@LZoog
Copy link
Copy Markdown
Contributor

@LZoog LZoog commented Jan 7, 2025

Because:

  • This script is sometimes useful for debugging emails and seeing true link output with UTM params etc.

This commit:

  • Restores the script from the commit prior to a3c090, with one tweak on config import

This script is noted in our ecosystem-platform docs here, I'm wondering if it was removed accidentally here? While we don't usually need it, sometimes it's useful for debugging, and I'd like to use it to help me debug why an EJS variable passing to Fluent in plain text isn't working. I'll just rebase on top of this temporarily to debug, but wanted to open this as well.

Looks like a test file for this was also removed that I could potentially restore here too, but when finding where this was removed I saw another comment where it was unexpectedly failing so if this is just a tool we use once a year to help with something then I don't know if we need it running in CI on every PR.

Because:
* This script is sometimes useful for debugging emails and seeing true link output with UTM params etc.

This commit:
* Restores the script from the commit prior to a3c090, with one tweak on config import
@LZoog LZoog marked this pull request as ready for review January 15, 2025 15:17
@LZoog LZoog requested a review from a team as a code owner January 15, 2025 15:17
@LZoog
Copy link
Copy Markdown
Contributor Author

LZoog commented Jan 15, 2025

I'm going to go ahead and merge this without the tests since it's a debug tool that we only need rarely and I saw at least one PR where they appeared to be flaky. We can revisit later if we want to. If we need to use this script later and see failures we can just copy the message object from our unit tests and paste it over her.

@LZoog LZoog merged commit 3920e37 into main Jan 15, 2025
@LZoog LZoog deleted the restore-write-emails-to-disk branch January 15, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants