feat(auth): Restore write-emails-to-disk script#18189
Merged
Conversation
Because: * This script is sometimes useful for debugging emails and seeing true link output with UTM params etc. This commit: * Restores the script from the commit prior to a3c090, with one tweak on config import
dschom
approved these changes
Jan 14, 2025
Contributor
Author
|
I'm going to go ahead and merge this without the tests since it's a debug tool that we only need rarely and I saw at least one PR where they appeared to be flaky. We can revisit later if we want to. If we need to use this script later and see failures we can just copy the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
This script is noted in our ecosystem-platform docs here, I'm wondering if it was removed accidentally here? While we don't usually need it, sometimes it's useful for debugging, and I'd like to use it to help me debug why an EJS variable passing to Fluent in plain text isn't working. I'll just rebase on top of this temporarily to debug, but wanted to open this as well.
Looks like a test file for this was also removed that I could potentially restore here too, but when finding where this was removed I saw another comment where it was unexpectedly failing so if this is just a tool we use once a year to help with something then I don't know if we need it running in CI on every PR.