feat(emails): Add inactiveAccountFirstWarning email template + partials by vpomerleau · Pull Request #18202 · mozilla/fxa

vpomerleau · 2025-01-09T02:03:23Z

Because

We will be sending out warnings before deleting inactive accounts

This pull request

Adds new email template for inactiveAccountFirstWarning including l10n and storybook
Adds new partials for use in inactive account emails
Adds stories for automated email partials

Issue that this pull request solves

Closes: #FXA-10636

Checklist

Put an x in the boxes that apply

My commit is GPG signed.
If applicable, I have modified or added tests which pass locally.
I have added necessary documentation (if appropriate).
I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

vbudhram

@vpomerleau Thank you! On a side note, this email is pretty much identical to https://mozilla-hub.atlassian.net/browse/FXA-10637 minus subject, title and extra note in description . For what it is worth the duplication seems alright to me. I could extact to more partials? What do you think?

vpomerleau · 2025-01-09T20:08:36Z

@vpomerleau Thank you! On a side note, this email is pretty much identical to https://mozilla-hub.atlassian.net/browse/FXA-10637 minus subject, title and extra note in description . For what it is worth the duplication seems alright to me. I could extact to more partials? What do you think?

I'd agree that the duplication seems fine to me, similar to our verification reminder emails. And I assume we'll have separate handlers for each so having 1:1 between handlers and templates seems fine. Keeping them separate makes it easier to tweak the copy of one of the emails if we need to in the future.

LZoog · 2025-01-09T20:31:25Z

@vbudhram I think it makes sense to document partials when they can be displayed in various ways, like the userInfo partial. I don't know if it's particularly useful for other partials though - but definitely for our footers it's useful imo!

LZoog · 2025-01-09T20:32:24Z

+import { storyWithProps } from '../../storybook-email';
+
+export default {
+  title: 'Partials/automatedEmail/automatedEmailChangePassword',


Can we put this under Partials/footers/*? I think it'll make it a lot more obvious for Product etc. when they're looking at storybook, that this is going to show our footers.

Sure thing.

I think @vbudhram was asking if he should extract more content of these inactive account emails into partials (vs questioning if we should add storybooks for the partials :))

bcolsson · 2025-01-09T21:21:13Z

@@ -0,0 +1,4 @@
+account-deletion-info-block-communications = If your account is deleted, you’ll still receive emails from { -brand-mozilla-corporation } and { -brand-mozilla-foundation }, unless you <a data-l10n-name="unsubscribeLink">ask to unsubscribe</a>.


Instead of creating terms here, let's hardcode them. This is what we do elsewhere like Firefox since using them are so uncommon.
Also, in these cases we don't want to use the existing Mozilla brand term either. (e.g. Mozilla Corporation and Mozilla Foundation not { -brand-mozilla } Corporationand { -brand-mozilla } Foundation`)

Apart from those reasons, the main reason we probably don't want to use terms is because of issues with fallbacking. If a locale weren't able to translate these emails in time before sending, I'd assume they'd fall back to English. However, terms / strings referenced by a placeholder won't fallback if the referenced term doesn't exist, instead it would just show the placeholder and { -brand-mozilla-corporation } would appear as-is.

bcolsson · 2025-01-09T21:22:33Z

@@ -0,0 +1 @@
+automated-email-inactive-account = This is an automated email. You are receiving it because you have a Mozilla account and it has been 2 years since your last sign-in.


We should use the -product-mozilla-account term here however. (Unless there's a technical reason not to.)

bcolsson · 2025-01-09T21:25:12Z

@@ -0,0 +1,10 @@
+inactiveAccountFirstWarning-subject = Remember to confirm your account
+inactiveAccountFirstWarning-title = Do you want to keep your { -brand-mozilla } account and data?


Suggested change

inactiveAccountFirstWarning-title = Do you want to keep your { -brand-mozilla } account and data?

inactiveAccountFirstWarning-title = Do you want to keep your { -product-mozilla-account } and data?

From my understanding Mozilla account does mean an individual's account so should we use -product-mozilla-account here?

This one I wasn't sure about since Mozilla seemed to apply to both the account and the data, but maybe that's fine and localizers can work around it.

I too was unsure. Yeah maybe what you have is better in terms of providing localizers the flexibility.

bcolsson · 2025-01-09T21:30:40Z

@@ -0,0 +1,10 @@
+inactiveAccountFirstWarning-subject = Remember to confirm your account
+inactiveAccountFirstWarning-title = Do you want to keep your { -brand-mozilla } account and data?
+inactiveAccountFirstWarning-account-description = Your { -product-mozilla-account } is used to access free privacy and browsing products like Firefox Sync, Monitor, Relay, and MDN.</span>


We should use the brand terms that exist for Relay, MDN, etc.

Also, "Firefox Sync" we don't treat as a product anymore.

I'll ask for content review on this in Figma. Our product terms are Mozilla Monitor and Firefox Relay, so I want to confirm what we should do in this case.

Just an update that content review is in progress for how to reference 'sync' in this sentence, and the other products will be updated to full names (Mozilla Monitor, Firefox Relay) so we can use the existing brand terms.

@bcolsson content was updated/reviewed/approved in Figma based on your comments and I've pushed up changes to this PR. Could you take another look? 🙇‍♀️

Because: * We will be sending out warnings before deleting inactive accounts This commit: * Adds new email template for inactiveAccountFirstWarning including l10n and storybook * Adds new partials for use in inactive account emails * Adds stories for automated email partials Closes #FXA-10636

vpomerleau commented Jan 9, 2025

View reviewed changes

Comment thread packages/fxa-auth-server/lib/senders/emails/templates/inactiveAccountFirstWarning/index.mjml

vbudhram reviewed Jan 9, 2025

View reviewed changes

Comment thread libs/shared/l10n/src/lib/branding.ftl Outdated

Comment thread packages/fxa-auth-server/lib/senders/emails/templates/inactiveAccountFirstWarning/index.mjml

vpomerleau marked this pull request as ready for review January 9, 2025 18:30

vpomerleau requested review from a team as code owners January 9, 2025 18:30

vpomerleau force-pushed the FXA-10636 branch from 90d8abc to f4834b9 Compare January 9, 2025 18:35

vbudhram approved these changes Jan 9, 2025

View reviewed changes

Comment thread ...es/fxa-auth-server/lib/senders/emails/templates/inactiveAccountFirstWarning/index.stories.ts

LZoog reviewed Jan 9, 2025

View reviewed changes

vpomerleau force-pushed the FXA-10636 branch from f4834b9 to afaf110 Compare January 9, 2025 20:45

bcolsson requested changes Jan 9, 2025

View reviewed changes

vpomerleau force-pushed the FXA-10636 branch from afaf110 to 476d123 Compare January 10, 2025 17:37

vbudhram mentioned this pull request Jan 10, 2025

Add second warning email template for delete inactive accounts #18204

Closed

4 tasks

vpomerleau force-pushed the FXA-10636 branch from 476d123 to 52dbb4d Compare January 10, 2025 22:34

vpomerleau requested a review from bcolsson January 10, 2025 22:39

bcolsson approved these changes Jan 11, 2025

View reviewed changes

vpomerleau merged commit 3932c3e into main Jan 13, 2025

vpomerleau deleted the FXA-10636 branch January 13, 2025 18:52

		@@ -0,0 +1,4 @@
		account-deletion-info-block-communications = If your account is deleted, you’ll still receive emails from { -brand-mozilla-corporation } and { -brand-mozilla-foundation }, unless you <a data-l10n-name="unsubscribeLink">ask to unsubscribe</a>.

		@@ -0,0 +1 @@
		automated-email-inactive-account = This is an automated email. You are receiving it because you have a Mozilla account and it has been 2 years since your last sign-in.

		@@ -0,0 +1,10 @@
		inactiveAccountFirstWarning-subject = Remember to confirm your account
		inactiveAccountFirstWarning-title = Do you want to keep your { -brand-mozilla } account and data?

Conversation

vpomerleau commented Jan 9, 2025

Because

This pull request

Issue that this pull request solves

Checklist

Screenshots (Optional)

Other information (Optional)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vbudhram left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vpomerleau commented Jan 9, 2025

Uh oh!

LZoog commented Jan 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants