feat(emails): Localize email preheaders#18205
Merged
vpomerleau merged 1 commit intomainfrom Jan 13, 2025
Merged
Conversation
Because: * Email preheaders were not localized * MJML has a dedicated tag for email previews This commit: * Remove preHeader passed in template values * Set preview content in email templates instead of handler * Use MJML mj-preview to set preview text * Add localization handling for preview text Closes #FXA-8558
bcolsson
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #FXA-8558
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Maildev does not show previews, which makes it harder to validate this change locally. I have verified that the preview text is included in the email source and hidden from view (as expected for preview text), but this might need to be validated on stage to ensure it works as expected.