feat(next): Redirect next app to default locale for invalid locales#18206
Merged
david1alvarez merged 1 commit intomainfrom Jan 14, 2025
Merged
feat(next): Redirect next app to default locale for invalid locales#18206david1alvarez merged 1 commit intomainfrom
david1alvarez merged 1 commit intomainfrom
Conversation
david1alvarez
force-pushed
the
FXA-10440
branch
from
47c3e4f to
d29fac0
Compare
vpomerleau
reviewed
Jan 10, 2025
StaberindeZA
approved these changes
Jan 13, 2025
david1alvarez
force-pushed
the
FXA-10440
branch
from
d29fac0 to
9dd5717
Compare
david1alvarez
changed the title
david1alvarez
force-pushed
the
FXA-10440
branch
from
9dd5717 to
b9e61d8
Compare
Because: * The next app uses routing to handle locale indication, but has no rerouting fallback functionality for improper locales. This commit: * Adds functionality to the Next.js middleware to catch incoming requests to next app on routes other than: api|_next/static|_next/image|favicon.ico|__heartbeat__|__lbheartbeat__|__version__ Closes FXA-10440
david1alvarez
force-pushed
the
FXA-10440
branch
from
b9e61d8 to
6e2f63a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This pull request:
Issue that this pull request solves
Closes FXA-10440
Checklist
Put an
xin the boxes that apply