feat(cloud tasks): add route handler for inactive notification cloud tasks#18212
Merged
feat(cloud tasks): add route handler for inactive notification cloud tasks#18212
Conversation
chenba
force-pushed
the
FXA-10572-create-cloud-task-endpoint
branch
from
5f6f4f2 to
b0997d7
Compare
vbudhram
approved these changes
Jan 13, 2025
| httpMethod: 1, // POST | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| 'fxa-cloud-task-delivery-time': '1741684000000', |
Contributor
There was a problem hiding this comment.
Might make sense to pull these into a constant with deliveryTime above.
|
|
||
| const { cloudTaskRoutes } = require('./cloud-tasks'); | ||
| const cloudTasks = cloudTaskRoutes(log, config); | ||
| const cloudTasks = cloudTaskRoutes(log, config, statsd); |
Contributor
There was a problem hiding this comment.
Stinks that statsd is passed in vs DI. We have been using it in alot more places.
Contributor
Author
There was a problem hiding this comment.
I usually try to be consistent with what's already in place.
…tasks Because: - we need an endpoint to accept the requests of the inactive account deletion email notification cloud tasks This commit: - adds the endpoint and handler - adds task auto-rescheduling based on a new delivery time option - refactors/updates some code to rely on the auto-rescheduling feature
chenba
force-pushed
the
FXA-10572-create-cloud-task-endpoint
branch
from
b0997d7 to
b6ada73
Compare
Contributor
Author
|
The failing functional test is a known issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This commit: