feat(scripts): remove subscriptions check from inactive deletions#18223
Merged
feat(scripts): remove subscriptions check from inactive deletions#18223
Conversation
chenba
force-pushed
the
fxa-inactives-remove-direct-subplat-checks
branch
from
35a289b to
fd697a1
Compare
vpomerleau
reviewed
Jan 14, 2025
| @@ -157,10 +153,6 @@ const init = async () => { | |||
| Container.set(CurrencyHelper, currencyHelper); | |||
Contributor
There was a problem hiding this comment.
Are the CurrencyHelper and StripeHelper still needed if not checking subscriptions?
Contributor
There was a problem hiding this comment.
+1 to above questions. Also authFirestore references, do we use that for anything else?
Contributor
Author
There was a problem hiding this comment.
Thank you for catching that. I will check. The thing with Container is that one cannot tell if something else in the dependency tree will reach in to grab something.
LZoog
approved these changes
Jan 15, 2025
| @@ -157,10 +153,6 @@ const init = async () => { | |||
| Container.set(CurrencyHelper, currencyHelper); | |||
Contributor
There was a problem hiding this comment.
+1 to above questions. Also authFirestore references, do we use that for anything else?
Because: - we want SubPlat to exclude account in the same fashion as other RPs, by providing a list - checking for a record in the `accountCustomers` table was not the correct way of checking for an active Stripe subscription This commit: - remove the subscription part of the active status check in the scripts
chenba
force-pushed
the
fxa-inactives-remove-direct-subplat-checks
branch
from
fd697a1 to
61f67d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
accountCustomerstable was not the correct way of checking for an active Stripe subscriptionThis commit: