Conversation
Trinaa
force-pushed
the
fxa-10807
branch
2 times, most recently
from
94dd9f7 to
ebe27d7
Compare
Trinaa
commented
Jan 17, 2025
Comment on lines
-335
to
-336
| JEST_JUNIT_OUTPUT_DIR: ./artifacts/tests | ||
| JEST_JUNIT_ADD_FILE_ATTRIBUTE: true |
Contributor
Author
There was a problem hiding this comment.
Not sure why these are here, they have no impact for Playwright.
Trinaa
commented
Jan 17, 2025
Comment on lines
-734
to
-736
| # Deprecated - use workflows in conjunction with smoke-tests job instead! | ||
| # This job is manually triggered for now. see .circleci/README.md | ||
| production-smoke-tests: |
Contributor
Author
There was a problem hiding this comment.
I don't think we need to keep this, it's not referenced anywhere in the workflows .
Contributor
There was a problem hiding this comment.
That sounds reasonable, I see that the readme instructions for triggering manually were deleted.
Contributor
There was a problem hiding this comment.
They get triggered remotely by SRE when we release. I don't think we can remove these. I will double check though.
Contributor
Author
There was a problem hiding this comment.
I am fairly certain what is happening is SRE is calling the production_smoke_tests workflow, which uses the smoke-tests job, not the production-smoke-tests job here.
dschom
reviewed
Jan 17, 2025
|
|
||
| // If using the CircleCI parallelism feature, assure that the JUNIT XML report | ||
| // has a unique name | ||
| const JUNIT_OUTPUT_NAME = process.env.CIRCLE_NODE_INDEX |
Because: * the HTML reports aren't widely used * there are alternative means of viewing results and traces * creating the HTML reports costs time and money This commit: * removes the creation of HTML reports from CI Closes #FXA-10807
dschom
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #FXA-10807
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.