Skip to content

bug(settings): Missing login_totp_code_trouble_link metric#18242

Merged
dschom merged 1 commit intomainfrom
FXA-10820
Jan 22, 2025
Merged

bug(settings): Missing login_totp_code_trouble_link metric#18242
dschom merged 1 commit intomainfrom
FXA-10820

Conversation

@dschom
Copy link
Copy Markdown
Contributor

@dschom dschom commented Jan 17, 2025

Because

  • The login_totp_code_trouble_link was missing.

This pull request

  • Adds the login_totp_code_trouble_link metric via a data-glean-id on the link.

Issue that this pull request solves

Closes: # (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

Because
- The `login_totp_code_trouble_link` was missing.

This Commit:
- Adds the `login_totp_code_trouble_link` metric via a `data-glean-id` on the link.
@dschom dschom requested a review from a team as a code owner January 17, 2025 01:41
Copy link
Copy Markdown
Contributor

@vbudhram vbudhram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dschom Automatic glean events FTW

@dschom dschom merged commit 38c9faa into main Jan 22, 2025
@dschom dschom deleted the FXA-10820 branch January 22, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants