task(auth): Check recovery-phone enabled config for all endpoints

[dschom]

Because

• We want this config to gate all recovery-phone endpoints

This pull request

• Adds checks to see if config indicates recovery-phone is enabled.

Issue that this pull request solves

Closes: FXA-11020

Checklist

Put an x in the boxes that apply

• My commit is GPG signed.
• If applicable, I have modified or added tests which pass locally.
• I have added necessary documentation (if appropriate).
• I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

[vpomerleau]

Thanks for adding this safety in so we can make sure the feature is fully off when needed. I was wondering if we needed to differentiate between turning the feature off for adding new phones vs using existing phones as we're doing on the frontend but it's probably unnecessary/overkill.

• Would we want tests for when the config is set to false?

[vbudhram]

@dschom We also have this error

fxa/packages/fxa-auth-server/lib/error.js

Line 488 in 7e8a95f

AppError.featureNotEnabled = function (retryAfter) {

that could be thrown in the handler.

[dschom]

@vbudhram I like the error better. I'll change this for everything except the /available handler.

[dschom]

Thanks for adding this safety in so we can make sure the feature is fully off when needed. I was wondering if we needed to differentiate between turning the feature off for adding new phones vs using existing phones as we're doing on the frontend but it's probably unnecessary/overkill.

* Would we want tests for when the config is set to false?

Yes, I'd say its overkill. In the event we do need something like this, it's simple to add.

Personally I think adding test cases for when the config is set is kind of a 'low value' test case, so I did not add these; however, when I switched to using errors as @vbudhram suggested I went ahead and added some test cases for this.

[vbudhram]

Thanks!

[vbudhram]

👍🏽