Skip to content

polish(auth-client): Update auth client recovery-phone api#18266

Merged
dschom merged 2 commits intomainfrom
polish-auth-client-recovery-phone
Jan 23, 2025
Merged

polish(auth-client): Update auth client recovery-phone api#18266
dschom merged 2 commits intomainfrom
polish-auth-client-recovery-phone

Conversation

@dschom
Copy link
Copy Markdown
Contributor

@dschom dschom commented Jan 22, 2025

Because

  • This fell through the cracks in the backend sms spec.

This pull request

  • Updates the auth client to be inline with the backend endpoints.

Issue that this pull request solves

Closes: # (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

It's a bit unclear where this responsibility lies. Is this a back end task or a front end task? At any rate, this should make auth-client one to one with /recovery_phone/** endpoints.

@dschom dschom requested a review from a team as a code owner January 22, 2025 18:27
@dschom dschom requested review from LZoog and vpomerleau January 22, 2025 18:27
Copy link
Copy Markdown
Contributor

@vbudhram vbudhram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit unclear where this responsibility lies. Is this a back end task or a front end task? At any rate, this should make auth-client one to one with /recovery_phone/** endpoints

FWIW, I've always considered still a frontend task still the auth-client is primarily used in the front end.

Copy link
Copy Markdown
Contributor

@vpomerleau vpomerleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the missing methods! I just have one requested change.

Comment thread packages/fxa-auth-client/lib/client.ts Outdated
Co-authored-by: Valerie Pomerleau <vpomerleau@mozilla.com>
@dschom dschom requested a review from vpomerleau January 22, 2025 22:24
@dschom dschom merged commit 2615da7 into main Jan 23, 2025
@dschom dschom deleted the polish-auth-client-recovery-phone branch January 23, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants