Skip to content

feat(db-migrations): improved logging in patcher.mjs#18267

Merged
clouserw merged 2 commits intomainfrom
improve-db-migration-patcher-logging
Feb 19, 2025
Merged

feat(db-migrations): improved logging in patcher.mjs#18267
clouserw merged 2 commits intomainfrom
improve-db-migration-patcher-logging

Conversation

@emaydeck-mozilla
Copy link
Copy Markdown
Contributor

Because

  • The current version of this script only logs errors. It would be nice to include informational logging for better debugging and testing.

This pull request

  • Adds informational logging for the db-migrations patcher script.

Issue that this pull request solves

Closes: # N/A

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@emaydeck-mozilla emaydeck-mozilla self-assigned this Jan 22, 2025
Comment thread packages/db-migrations/bin/patcher.mjs Outdated
Comment thread packages/db-migrations/bin/patcher.mjs Outdated
Comment thread packages/db-migrations/bin/patcher.mjs Outdated
Copy link
Copy Markdown
Contributor

@dschom dschom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbuck jbuck marked this pull request as ready for review January 25, 2025 20:26
@jbuck jbuck requested a review from a team as a code owner January 25, 2025 20:26
@clouserw clouserw merged commit 39a64bd into main Feb 19, 2025
@clouserw clouserw deleted the improve-db-migration-patcher-logging branch February 19, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants