feat(next): Duplicate right-hand portion of fxa-settings header#18280
Merged
david1alvarez merged 1 commit intomainfrom Jan 28, 2025
Merged
feat(next): Duplicate right-hand portion of fxa-settings header#18280david1alvarez merged 1 commit intomainfrom
david1alvarez merged 1 commit intomainfrom
Conversation
Contributor
StaberindeZA
left a comment
StaberindeZA
left a comment
There was a problem hiding this comment.
This look good! Just some mostly minor inline comments.
xlisachan
reviewed
Jan 24, 2025
xlisachan
reviewed
Jan 24, 2025
xlisachan
reviewed
Jan 24, 2025
xlisachan
reviewed
Jan 24, 2025
xlisachan
reviewed
Jan 24, 2025
david1alvarez
force-pushed
the
FXA-7803
branch
4 times, most recently
from
b9c4009 to
a711fe3
Compare
david1alvarez
force-pushed
the
FXA-7803
branch
4 times, most recently
from
9cfa30c to
59e7c3d
Compare
david1alvarez
force-pushed
the
FXA-7803
branch
3 times, most recently
from
cf06480 to
3ec21b6
Compare
david1alvarez
commented
Jan 27, 2025
david1alvarez
force-pushed
the
FXA-7803
branch
7 times, most recently
from
afd58fc to
be600de
Compare
StaberindeZA
approved these changes
Jan 28, 2025
Contributor
StaberindeZA
left a comment
StaberindeZA
left a comment
There was a problem hiding this comment.
r+
Thank you for the changes and working through this.
Because: * The fxa-settings header contains functionality around upsells and cross-sells, and gives the user direct access to their signed-in status This commit: * rewrites the components to be up to standard for the content within the libs directory * Reworks the headers for the payments-next app to be compatible with new localization requirements * Brings the header up to parity Closes #FXA-7803
david1alvarez
force-pushed
the
FXA-7803
branch
from
be600de to
93903bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-7803
Checklist
Put an
xin the boxes that applyScreenshots (Optional)