Skip to content

feat(settings): Show banner when unverified accounts signin#18299

Merged
jonalmeida merged 1 commit intomainfrom
FXA-10983
Jan 29, 2025
Merged

feat(settings): Show banner when unverified accounts signin#18299
jonalmeida merged 1 commit intomainfrom
FXA-10983

Conversation

@jonalmeida
Copy link
Copy Markdown
Contributor

@jonalmeida jonalmeida commented Jan 28, 2025

Because

  • We want to show a banner when a user signs in after clicking an inactive account reminder email.

This pull request

  • Shows a banner when we receive particular UTM params from clicking links in the inactive account emails.
  • Adds metric account_banner_reactivation_success_view as custom metric.

Issue that this pull request solves

Fixes FXA-10983

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Screenshot 2025-01-28 at 10 58 34 AM

Other information (Optional)

  • Separated the metrics to different commit instead it's preferable to have it linked to another issue or PR.
  • For testing, add the UTM params when signing in. e.g. http://localhost:3030/signin?email=tester%40gmail.com&utm_medium=email&utm_campaign=fx-account-inactive-reminder-third&utm_content=fx-account-deletion

Comment thread packages/fxa-settings/src/components/Settings/PageSettings/index.tsx Outdated
Comment thread packages/fxa-settings/src/components/Settings/index.tsx Outdated
@jonalmeida jonalmeida marked this pull request as ready for review January 28, 2025 20:03
@jonalmeida jonalmeida requested review from a team as code owners January 28, 2025 20:03
Comment thread packages/fxa-settings/src/components/Settings/index.tsx Outdated
Comment thread packages/fxa-settings/src/components/Settings/PageSettings/en.ftl Outdated
Comment thread packages/fxa-settings/src/components/Settings/PageSettings/index.tsx Outdated
@jonalmeida jonalmeida force-pushed the FXA-10983 branch 3 times, most recently from e8cc431 to fa82ec0 Compare January 28, 2025 21:10
Comment thread packages/fxa-settings/src/components/Settings/PageSettings/en.ftl Outdated
@jonalmeida jonalmeida force-pushed the FXA-10983 branch 2 times, most recently from 748e642 to 4aed419 Compare January 29, 2025 17:02
Comment thread packages/fxa-settings/src/components/Settings/PageSettings/index.test.tsx Outdated
Comment thread packages/fxa-settings/src/components/Settings/PageSettings/en.ftl Outdated
@jonalmeida jonalmeida force-pushed the FXA-10983 branch 2 times, most recently from ca66b94 to ec9f846 Compare January 29, 2025 18:17
Copy link
Copy Markdown
Contributor

@LZoog LZoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Fixes FXA-10983

Co-authored-by: Lauren Zugai <lauren@zugai.com>
@jonalmeida jonalmeida merged commit 0eff38e into main Jan 29, 2025
@jonalmeida jonalmeida deleted the FXA-10983 branch January 29, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants