Skip to content

feat(next): add percentage based redirects to landing#18300

Merged
StaberindeZA merged 1 commit intomainfrom
fxa-10968-rollout-landing
Jan 28, 2025
Merged

feat(next): add percentage based redirects to landing#18300
StaberindeZA merged 1 commit intomainfrom
fxa-10968-rollout-landing

Conversation

@StaberindeZA
Copy link
Copy Markdown
Contributor

Because

  • Landing page needs to redirect to either payments-server or payments-next depending on configuration per offering.

This pull request

  • Adds SP2 redirect config to payments-next.
  • Adds a function to determine whether SP3 landing page should redirect to SP2 based on per offeringId percentage configuration.

Issue that this pull request solves

Closes: #FXA-10968

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

@StaberindeZA StaberindeZA requested a review from a team as a code owner January 28, 2025 17:19
@StaberindeZA StaberindeZA force-pushed the fxa-10968-rollout-landing branch from b9cc69e to f029d66 Compare January 28, 2025 17:21
Because:

- Landing page needs to redirect to either `payments-server` or
  `payments-next` depending on configuration per offering.

This commit:

- Adds SP2 redirect config to `payments-next`.
- Adds a function to determine whether SP3 landing page should redirect
  to SP2 based on per offeringId percentage configuration.

Closes #FXA-10968
@StaberindeZA StaberindeZA force-pushed the fxa-10968-rollout-landing branch from f029d66 to 08d76f3 Compare January 28, 2025 22:18
Copy link
Copy Markdown
Contributor

@xlisachan xlisachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Reino!

@StaberindeZA StaberindeZA merged commit 6fb15cc into main Jan 28, 2025
@StaberindeZA StaberindeZA deleted the fxa-10968-rollout-landing branch January 28, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants