Skip to content

task(auth): Have typescript target more files.#18365

Merged
dschom merged 1 commit intomainfrom
allow-@fxa-imports
Feb 12, 2025
Merged

task(auth): Have typescript target more files.#18365
dschom merged 1 commit intomainfrom
allow-@fxa-imports

Conversation

@dschom
Copy link
Copy Markdown
Contributor

@dschom dschom commented Feb 12, 2025

Because

  • We keep getting burned by '@fxa/' requires & imports

This pull request

  • Targets js files in tsconfig

Issue that this pull request solves

Closes: # (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

Because:
- We keep getting burned by '@fxa/' requires & imports

This Commit:
- Targets js files in tsconfig
@dschom dschom requested a review from a team as a code owner February 12, 2025 20:28
@dschom dschom merged commit bc4a158 into main Feb 12, 2025
@dschom dschom deleted the allow-@fxa-imports branch February 12, 2025 21:08
@dschom dschom mentioned this pull request Feb 13, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants