chore(tests): Fix mock import issue, more investigation needed #18374
Merged
chore(tests): Fix mock import issue, more investigation needed #18374
Conversation
LZoog
force-pushed
the
FXA-11044-mock-update
branch
from
2172619 to
12d1274
Compare
bcolsson
approved these changes
Feb 13, 2025
Contributor
bcolsson
left a comment
bcolsson
left a comment
There was a problem hiding this comment.
I don't believe this PR affects L10n from what I can see, so approving.
dschom
reviewed
Mar 6, 2025
| defaultAppContext, | ||
| SettingsContextValue, | ||
| } from '.'; | ||
| } from './contexts/AppContext'; |
dschom
approved these changes
Mar 6, 2025
LZoog
force-pushed
the
FXA-11044-mock-update
branch
from
12d1274 to
22bb1cf
Compare
Because: * This import was not being allowed, seemingly from a circular dependency somewhere This commit: * Changes the import to avoid the problem, but investigation is still needed co-authored-by: Dan Schomburg <94418270+dschom@users.noreply.github.com>
LZoog
force-pushed
the
FXA-11044-mock-update
branch
from
22bb1cf to
71dd5e2
Compare
Contributor
Author
|
Going to go ahead and merge this. A follow up ticket was filed: https://mozilla-hub.atlassian.net/browse/FXA-11293 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
branched from #18340
--
Because:
This commit: