Merged
Conversation
vbudhram
approved these changes
Feb 19, 2025
| const now = Date.now(); | ||
|
|
||
| // If the very first email hard bounced, we'll delete the account without | ||
| // sending further emails. |
Contributor
There was a problem hiding this comment.
nit: This might be helpul to be pulled into its own function for readiability.
Contributor
There was a problem hiding this comment.
Would we need to wrap this block in a try/catch? ie if the account delete task fails?
Contributor
Author
There was a problem hiding this comment.
This is in response to a cloud task so the task would retry.
Because: - we want to delete an inactive account if the first email notification was hard bounced This commit: - checks whether the first email hard bounced prior to sending the second email, and deletes the account if so
chenba
force-pushed
the
fxa-11070-inactive-bounce-check
branch
from
5c61145 to
5f91300
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This commit: