fix(paypal): Fix map accessing for paypal country code#18405
Merged
david1alvarez merged 1 commit intomainfrom Feb 19, 2025
Merged
fix(paypal): Fix map accessing for paypal country code#18405david1alvarez merged 1 commit intomainfrom
david1alvarez merged 1 commit intomainfrom
Conversation
julianpoy
approved these changes
Feb 19, 2025
david1alvarez
force-pushed
the
paypal-fix
branch
from
d56576d to
ff3d14b
Compare
Because: * The paypal country code logic is required by finance, but is a Map not a POJO, and can't be accessed via bracket notation This commit: * Fixes this Closes #
david1alvarez
force-pushed
the
paypal-fix
branch
from
ff3d14b to
be38ce0
Compare
StaberindeZA
approved these changes
Feb 19, 2025
|
@david1alvarez Is this ready to merge? Once merged, let's work with Dan to get it up to stage for further verification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
Closes #FXA-11174
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.