Conversation
julianpoy
force-pushed
the
FXA-10618
branch
6 times, most recently
from
734de3b to
e3e19db
Compare
StaberindeZA
left a comment
StaberindeZA
left a comment
There was a problem hiding this comment.
There are a few of payments-nexts external dependencies missing that we should gather request count and timings on as well.
- Content Server (libs/payments/content-server/**) - Used to fetch flow_id at start of checkout
- Google Maps services (libs/google/**) - Used in Tax Location picker
| } | ||
| await this.cartManager.finishCart(cart.id, version, {}); | ||
|
|
||
| this.statsd.increment('subscription_success', { |
There was a problem hiding this comment.
To keep track of the amount, would another counter make sense?
It'd be great to have live dashboards where we can show successful payments by payment_provider, and also have a "Total Sales" for the day/week/month type dashboard.
There was a problem hiding this comment.
I think Stripe's dashboard does a good job of this and I'd rather push us towards capturing there, but I'm not opposed to adding an additional counter for subscription_total_amount that increments by the dollar amount of the sub.
There was a problem hiding this comment.
I think it could be cool to be able to filter it by payment_provider and offering/interval, which is something Stripe doesn't currently make super easy afaik.
There was a problem hiding this comment.
I guess currency would need to be included as well. Hmm. If this ends up being too much effort for what its worth, happy to leave it for another time , if at all.
There was a problem hiding this comment.
Ah, good point about currency -- the amount is not standard since it's currency-dependent. I'd like to push this for now if that's alright
StaberindeZA
left a comment
StaberindeZA
left a comment
There was a problem hiding this comment.
r+. I'm seeing them locally. Thank you!
2 participants
Because
This pull request
Issue that this pull request solves
Closes FXA-10618
Closes FXA-8304