Skip to content

fix(sms): Set signed in state to true in apolloClient after using recovery phone and code#18456

Merged
vbudhram merged 1 commit intomainfrom
fxa-11207
Feb 26, 2025
Merged

fix(sms): Set signed in state to true in apolloClient after using recovery phone and code#18456
vbudhram merged 1 commit intomainfrom
fxa-11207

Conversation

@vbudhram
Copy link
Copy Markdown
Contributor

Because

  • The user is redirected back to signin after using recovery phone or code (after third party auth login)

This pull request

  • Sets the apollo cache to signed in and adds a small delay

Issue that this pull request solves

Closes: https://mozilla-hub.atlassian.net/browse/FXA-11207

Checklist

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Other information (Optional)

I spent a decent amount of time on this because just adding the apollo cache update did not consistenly make this pass. i suspect there is some state management issue between local storage and apollo cache that causes the user to be redirected back to signin. Adding a small delay consistently fixed the issue but its meh. I added a commend and think we can address this in the state refactoring.

@vbudhram vbudhram requested a review from a team as a code owner February 25, 2025 19:44
@vbudhram vbudhram self-assigned this Feb 25, 2025
Copy link
Copy Markdown
Contributor

@vpomerleau vpomerleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, WFM.

Would this be the ticket most related for updating state management?
https://mozilla-hub.atlassian.net/browse/FXA-11037

Failed checks don't seem caused by the PR, not sure what's going on there

@vbudhram vbudhram merged commit 9f1922a into main Feb 26, 2025
@vbudhram vbudhram deleted the fxa-11207 branch February 26, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants