feat(next): allow location change on active sub#18745
Merged
StaberindeZA merged 1 commit intomainfrom May 1, 2025
Merged
Conversation
StaberindeZA
force-pushed
the
fxa-11508-allow-active-loc-change
branch
2 times, most recently
from
1b39c55 to
615aed2
Compare
StaberindeZA
force-pushed
the
fxa-11508-allow-active-loc-change
branch
from
615aed2 to
e3c3bf8
Compare
julianpoy
reviewed
Apr 29, 2025
julianpoy
reviewed
Apr 29, 2025
Because: - Allow customers with active subscriptions to change tax location as long as currency isnt altered. - Display message informing customers that a change in tax location could impact all existing subscriptions. This commit: - Add new method to TaxService to check if a tax location change is allowed. - Consolidate location validity checks into ValidateLocationAction - Update Location and New pages, as well as SelectTaxLocation saveAction methods to use ValidateLocationAction - Adds message to SelectTaxLocation and is only shown when a customer has an active subscription. - For carts with state Start, add new field indicating whether or not an active subscription exists Closes #FXA-11508
StaberindeZA
force-pushed
the
fxa-11508-allow-active-loc-change
branch
from
e3c3bf8 to
db4e9f3
Compare
julianpoy
approved these changes
Apr 30, 2025
bcolsson
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #FXA-11508
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
New customer without active subscription
Existing customer with active subscription
