Skip to content

fix(next): sign out retains current location#18785

Merged
StaberindeZA merged 1 commit intomainfrom
fxa-11452-user-signout-redirect
Apr 30, 2025
Merged

fix(next): sign out retains current location#18785
StaberindeZA merged 1 commit intomainfrom
fxa-11452-user-signout-redirect

Conversation

@StaberindeZA
Copy link
Copy Markdown
Contributor

Because

  • When a customer has manually changed their location on the checkout page, and then signs out, the previously set location is not retained. This could result in the user being navigated to their default location instead of the location selected before sign out.

This pull request

  • Moves the Heading component into checkout and upgrade layouts
  • Pass countryCode and postalCode to the /new page when a customers signs out and is redirected there.

Issue that this pull request solves

Closes: FXA-11452

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

Because:

- When a customer has manually changed their location on the checkout
  page, and then signs out, the previously set location is not retained.
  This could result in the user being navigated to their default
  location instead of the location selected before sign out.

This commit:

- Moves the Heading component into checkout and upgrade layouts
- Pass countryCode and postalCode to the /new page when a customers
  signs out and is redirected there.

Closes #FXA-11452
@StaberindeZA StaberindeZA requested a review from a team as a code owner April 29, 2025 17:17
Copy link
Copy Markdown
Contributor

@xlisachan xlisachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+, thanks Reino!

@StaberindeZA StaberindeZA merged commit 9a9942c into main Apr 30, 2025
20 checks passed
@StaberindeZA StaberindeZA deleted the fxa-11452-user-signout-redirect branch April 30, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants