fix(next): missing metadata on upgrade#18803
Merged
StaberindeZA merged 1 commit intomainfrom May 2, 2025
Merged
Conversation
Because: - On a subscription upgrade, `plan_change_date` and `previous_plan_id` need to be added to the subscription metadata. This commit: - Adds missing `plan_change_date` and `previous_plan_id` to subscription updates. Closes #FXA-11540
xlisachan
approved these changes
May 2, 2025
Contributor
xlisachan
left a comment
xlisachan
left a comment
There was a problem hiding this comment.
r+, thanks Reino!
I pulled down your branch and created/upgraded subscriptions using both credit card and PayPal. I see both previous_plan_id and plan_change_date in the subscription metadata! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
plan_change_dateandprevious_plan_idneed to be added to the subscription metadata.This pull request
plan_change_dateandprevious_plan_idto subscription updates.Issue that this pull request solves
Closes: FXA-11540
Checklist
Put an
xin the boxes that applyScreenshots (Optional)