task(settings): Improve error handling for gql errors and network errors#18806
Merged
task(settings): Improve error handling for gql errors and network errors#18806
Conversation
dschom
force-pushed
the
improve-gql-breadcrumbs
branch
5 times, most recently
from
de9a71c to
2fdc5d3
Compare
Because: - We were seeing network errors in sentry, but couldn't tell where they originated. This Commit: - Adds apollo links so we can get more visibility into gql queries - Adds a comment about how sentry records failed fetch events, since the Sentry UI is a little ambiguous
dschom
force-pushed
the
improve-gql-breadcrumbs
branch
from
2fdc5d3 to
92804ce
Compare
vpomerleau
approved these changes
May 7, 2025
Contributor
vpomerleau
left a comment
vpomerleau
left a comment
There was a problem hiding this comment.
Thanks! This should be really helpful for investigating issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-10879 (Partially)
(This should help us determine what GQL are actually failing. The issue will still persist until the underlying problems are corrected.)
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.