Skip to content

task(auth-server): Don't report retryAfter to statsd on customs check events#18847

Merged
dschom merged 1 commit intomainfrom
FXA-11492
May 9, 2025
Merged

task(auth-server): Don't report retryAfter to statsd on customs check events#18847
dschom merged 1 commit intomainfrom
FXA-11492

Conversation

@dschom
Copy link
Copy Markdown
Contributor

@dschom dschom commented May 9, 2025

Because

  • We don't want to send values with high cardinality to stats

This pull request

  • Ensures retryAfter isn't sent

Issue that this pull request solves

Closes: FXA-11492

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@dschom dschom requested a review from a team as a code owner May 9, 2025 01:36
Copy link
Copy Markdown
Contributor

@chenba chenba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Dan.

For anyone following along, we already configured Telegraf to ignore the 'retryAfter' tag. It was necessary to stablise the service.

@dschom dschom merged commit bebdf23 into main May 9, 2025
19 checks passed
@dschom dschom deleted the FXA-11492 branch May 9, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants